You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Direct cast from ICredentials to PasswordCredentials could throw InvalidCastException if credentials are of a different type. Should use 'as' operator or pattern matching with null check.
Add null check and type validation for authenticationHandler.Credentials before casting to PasswordCredentials to prevent potential runtime exceptions.
-PasswordCredentials credentials = (PasswordCredentials)authenticationHandler.Credentials;+if (authenticationHandler.Credentials is not PasswordCredentials credentials)+{+ throw new InvalidOperationException("Authentication handler credentials must be of type PasswordCredentials");+}
Apply this suggestion
Suggestion importance[1-10]: 8
Why: The suggestion addresses a potential runtime error by adding proper type validation and null checking before casting credentials, which could prevent crashes and improve error handling.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Annotate nullability on network interactions
Motivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Annotated nullability across network-related classes and methods.
Added null-checks and exception handling for method parameters.
Introduced nullable reference types in multiple files.
Improved code clarity and fixed typos in comments.
Changes walkthrough 📝
8 files
Enable nullable reference types and add null-checks.Add null-checks and enable nullable reference types.Add null-checks and enable nullable reference types.Add null-checks and enable nullable reference types.Add null-checks and enable nullable reference types.Enable nullable reference types for credentials interface.Enable nullable reference types for password credentials.Add constructors and nullable reference types for user agent.1 files
Refactor type casting and improve null safety.